Skip to content

perf: persist Snap accounts only once #15027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

perf: persist Snap accounts only once #15027

merged 3 commits into from
May 5, 2025
+5 −7

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Apr 30, 2025

Description

The AccountsController is already listening to the KeyringController:stateChange event and will automatically adds newly created account from every keyrings. This would avoid triggering an unnecessary AccountsController:stateChange.

Related issues

N/A

Manual testing steps

  1. Make a beta build
  2. Creates a Solana account
  3. It should be created just as before

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly added team-accounts area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. labels Apr 30, 2025
@ccharly ccharly self-assigned this Apr 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly added the No QA Needed Apply this label when your PR does not need any QA effort. label Apr 30, 2025
@ccharly ccharly marked this pull request as ready for review May 5, 2025 09:25
@ccharly ccharly requested a review from a team as a code owner May 5, 2025 09:25
@ccharly ccharly linked an issue May 5, 2025 that may be closed by this pull request
[Bug]: performance degradation during account creation #14864
Closed
gantunesr
gantunesr approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Did not test it

@gantunesr gantunesr added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 40b4f65
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b7b8db7f-7ae1-447f-8f5c-580e38f0ab3d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ccharly ccharly enabled auto-merge May 5, 2025 16:35
@ccharly ccharly disabled auto-merge May 5, 2025 16:35
@ccharly ccharly enabled auto-merge May 5, 2025 19:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ccharly ccharly added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 723225d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/87166dc4-9cee-429c-9ea0-ba9709d1b45b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@ccharly ccharly added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit c661f30 May 5, 2025
49 of 51 checks passed
@ccharly ccharly deleted the perf/persist-snap-accounts-once branch May 5, 2025 20:40
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

@ccharly ccharly

Labels
area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: performance degradation during account creation
4 participants
@ccharly @gantunesr @tommasini @metamaskbot